Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support specifying osversion in the --platform flag #1206

Merged
merged 1 commit into from
Dec 15, 2021

Conversation

imjasonh
Copy link
Collaborator

This removes the --osversion flag, and lets users specify the osversion
in the --platform flag itself, separated by a ":"

For example:

crane manifest golang:1.17 --platform=windows/amd64:10.0.17763.2366

This matches the proposed behavior in ko-build/ko#536

cc @phillipsj -- is this format acceptable for your uses? ko has a stronger need to be able to specify the osversion in the platform, since it allows specifying multiple values, but I'd really like to keep them aligned if we can.

This removes the --osversion flag, and lets users specify the osversion
in the --platform flag itself, separated by a ":"

For example:

    crane manifest golang:1.17 --platform=windows/amd64:10.0.17763.2366
@codecov-commenter
Copy link

codecov-commenter commented Dec 15, 2021

Codecov Report

Merging #1206 (e98515f) into main (379f5ca) will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##             main    #1206   +/-   ##
=======================================
  Coverage   74.55%   74.55%           
=======================================
  Files         111      111           
  Lines        8050     8050           
=======================================
  Hits         6002     6002           
  Misses       1464     1464           
  Partials      584      584           

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 379f5ca...e98515f. Read the comment docs.

@phillipsj
Copy link
Contributor

phillipsj commented Dec 15, 2021 via email

@imjasonh imjasonh merged commit ab77ea6 into google:main Dec 15, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants