Support specifying osversion in the --platform flag #1206
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This removes the --osversion flag, and lets users specify the osversion
in the --platform flag itself, separated by a ":"
For example:
This matches the proposed behavior in ko-build/ko#536
cc @phillipsj -- is this format acceptable for your uses?
ko
has a stronger need to be able to specify the osversion in the platform, since it allows specifying multiple values, but I'd really like to keep them aligned if we can.