Re-exec gcloud token source when we refresh #1017
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Previously, this was storing a single exec.Command, but that gets consumed when it gets Run, failing with: exec: already started This will re-exec the gcloud when needed.
Codecov Report
@@ Coverage Diff @@
## main #1017 +/- ##
=======================================
Coverage 75.22% 75.22%
=======================================
Files 107 107
Lines 5053 5053
=======================================
Hits 3801 3801
Misses 706 706
Partials 546 546
Continue to review full report at Codecov.
|
ardagnir
approved these changes
May 13, 2021
briandealwis
added a commit
to briandealwis/skaffold
that referenced
this pull request
May 21, 2021
briandealwis
added a commit
to GoogleContainerTools/skaffold
that referenced
this pull request
May 21, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Previously, this was storing a single exec.Command, but that gets
consumed when it gets Run, failing with:
exec: already started
This will re-exec the gcloud when needed.