-
Notifications
You must be signed in to change notification settings - Fork 812
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
all: initial module-geddon commit for testing #2189
Conversation
Please edit the title of this pull request with the name of the affected package, or "all", followed by a colon, followed by a short summary of the change. Example: |
Codecov Report
@@ Coverage Diff @@
## master #2189 +/- ##
==========================================
+ Coverage 71.01% 77.75% +6.74%
==========================================
Files 103 78 -25
Lines 12337 9391 -2946
==========================================
- Hits 8761 7302 -1459
+ Misses 2942 1567 -1375
+ Partials 634 522 -112 Continue to review full report at Codecov.
|
internal/testing/alldeps
Outdated
@@ -41,28 +41,21 @@ github.com/gorilla/mux | |||
github.com/grpc-ecosystem/grpc-gateway | |||
github.com/hashicorp/errwrap | |||
github.com/hashicorp/go-cleanhttp | |||
github.com/hashicorp/go-hclog |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Why would alldeps
change in this way?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Good spot. Will revert the vault bump that caused this
internal/website/data/examples.json
Outdated
@@ -127,22 +127,6 @@ | |||
"imports": "import (\n\t\"context\"\n\n\t\"gocloud.dev/pubsub\"\n\t_ \"gocloud.dev/pubsub/gcppubsub\"\n)", | |||
"code": "topic, err := pubsub.OpenTopic(ctx, \"gcppubsub://myproject/mytopic\")\nif err != nil {\n\treturn err\n}\ndefer topic.Shutdown(ctx)" | |||
}, | |||
"gocloud.dev/pubsub/kafkapubsub.ExampleOpenSubscription": { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This change to examples.json
looks wrong. We probably need to run gatherexamples
over all modules or something...?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yep, fixed the gathering script to use allmodules
Travis is green. Moving to the next step now -- removing all |
This should be ready to go with @vangent's LGTM [removed Travis requirement from branch protection so I could merge this] |
No description provided.