Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

runtimevar/gcpruntimeconfig: re-record goldens using the team project, not my private one #2179

Merged
merged 1 commit into from
May 30, 2019

Conversation

vangent
Copy link
Contributor

@vangent vangent commented May 30, 2019

Ooops :-).

@vangent vangent requested a review from shantuo May 30, 2019 00:41
@googlebot googlebot added the cla: yes Google CLA has been signed! label May 30, 2019
@codecov
Copy link

codecov bot commented May 30, 2019

Codecov Report

Merging #2179 into master will decrease coverage by 0.04%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #2179      +/-   ##
==========================================
- Coverage   71.04%   70.99%   -0.05%     
==========================================
  Files         104      104              
  Lines       12485    12485              
==========================================
- Hits         8870     8864       -6     
- Misses       2978     2983       +5     
- Partials      637      638       +1
Impacted Files Coverage Δ
internal/retry/retry.go 88.23% <0%> (-11.77%) ⬇️
internal/cmd/gocdk/main.go 45.07% <0%> (-2.82%) ⬇️
pubsub/kafkapubsub/kafka.go 83.39% <0%> (-0.74%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 7ab9ebe...3aecf4a. Read the comment docs.

@shantuo shantuo merged commit 39aafdc into google:master May 30, 2019
@vangent vangent deleted the rerecord branch May 30, 2019 19:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cla: yes Google CLA has been signed!
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants