Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

allmodules: mark modules into categories #2111

Closed
eliben opened this issue May 15, 2019 · 0 comments · Fixed by #2289
Closed

allmodules: mark modules into categories #2111

eliben opened this issue May 15, 2019 · 0 comments · Fixed by #2289
Assignees
@eliben
Labels
enhancement New feature or request process Improvement to the engineering process

Comments

@eliben
Copy link
Member

eliben commented May 15, 2019

Right now we have an allmodules file that just lists all the modules (directories where go.mod resides):

.
internal/cmd/gocdk
internal/contributebot
internal/website
samples

A couple of scripts use these lists of modules to perform tasks "for all modules in the repo".

As part of the work on #886, we'll need tooling to help with the release process. This tooling will need to distinguish between several categories of modules:

  1. The root module (admittedly, it's easy as it's the only one that is .)
  2. Submodules that we plan to release/track, such as separate providers split out from root as part of all: dividing go-cloud into more than one module #886
  3. Samples modules that import all the other released modules
  4. Modules we use only internally and don't release. These don't need tagging

For example, prior to a release, a tool will have to add replace lines to all released modules that depend on root so they can be tested with the newest version. Same for samples depending on root and other released modules. Et cetera
@eliben eliben added enhancement New feature or request process Improvement to the engineering process labels May 15, 2019
@eliben eliben self-assigned this May 15, 2019
This was referenced May 15, 2019
Merged
Closed
@eliben eliben mentioned this issue Jun 7, 2019
Closed
eliben added a commit to eliben/go-cloud that referenced this issue Jun 7, 2019
@eliben
testing: Add option to have extra fields in allmodules
11cefab 
This PR teaches all our shell scripts that procses allmodules to ignore
any additional whitespace-separated fields.

The next step will be to add special purpose fields for selective
tagging -- google#2284

Updates google#2111
@eliben eliben mentioned this issue Jun 7, 2019
Merged
eliben added a commit to eliben/go-cloud that referenced this issue Jun 7, 2019
@eliben
release: add 'tag' command to releashelper
a0eb1fe 
This command runs 'git tag' to set a tag on all released modules. For
this purpose we start marking modules in allmodule as "released" or not.

Fixes google#2284
Fixes google#2111
@eliben eliben mentioned this issue Jun 7, 2019
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@eliben eliben

Labels
enhancement New feature or request process Improvement to the engineering process
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

release: add 'tag' command to releashelper eliben/go-cloud
1 participant
@eliben