Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Vulkan: Add wireframe view support #888

Merged
merged 1 commit into from
Aug 11, 2017
Merged

Vulkan: Add wireframe view support #888

merged 1 commit into from
Aug 11, 2017

Conversation

Qining
Copy link
Contributor

@Qining Qining commented Aug 9, 2017

Fix issue #817

@Qining Qining requested review from AWoloszyn and ben-clayton August 9, 2017 20:47
ben-clayton
ben-clayton approved these changes Aug 10, 2017
View reviewed changes
Copy link
Contributor

@ben-clayton ben-clayton left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM - nice!

@Qining Qining merged commit bfdcf0e into google:master Aug 11, 2017
@Qining Qining mentioned this pull request Aug 11, 2017
Open
@Qining Qining deleted the vulkan-wireframe-view branch February 6, 2018 14:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ben-clayton ben-clayton ben-clayton approved these changes

@AWoloszyn AWoloszyn Awaiting requested review from AWoloszyn

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@Qining @ben-clayton