Update Perfetto & UI to show vulkan debug markers in the properties pane #3697
Conversation
gapic/src/main/com/google/gapid/perfetto/models/SliceTrack.java
Outdated
Show resolved
Hide resolved
| private final String table; | ||
| private final long trackId; | ||
| protected final String table; | ||
| protected final long trackId; |
There was a problem hiding this comment.
Let's reorder these to put protected and private together
There was a problem hiding this comment.
I think its better to have all the queries together for a neater look. But I can reorder them if needed.
There was a problem hiding this comment.
Yes, let's not impose arbitrary ordering.
gapic/src/main/com/google/gapid/perfetto/models/SliceTrack.java
Outdated
Show resolved
Hide resolved
gapic/src/main/com/google/gapid/perfetto/models/SliceTrack.java
Outdated
Show resolved
Hide resolved
gapic/src/main/com/google/gapid/perfetto/models/SliceTrack.java
Outdated
Show resolved
Hide resolved
gapic/src/main/com/google/gapid/perfetto/models/SliceTrack.java
Outdated
Show resolved
Hide resolved
gapic/src/main/com/google/gapid/perfetto/views/GpuQueuePanel.java
Outdated
Show resolved
Hide resolved
gapic/src/main/com/google/gapid/perfetto/models/SliceTrack.java
Outdated
Show resolved
Hide resolved
silence-do-good
force-pushed
the
RemoveFrameBufferHandle
branch
4 times, most recently
from
f6eb510 to
4083f8a
Compare
gapic/src/main/com/google/gapid/perfetto/models/SliceTrack.java
Outdated
Show resolved
Hide resolved
gapic/src/main/com/google/gapid/perfetto/views/SliceSelectionView.java
Outdated
Show resolved
Hide resolved
gapic/src/main/com/google/gapid/perfetto/views/SliceSelectionView.java
Outdated
Show resolved
Hide resolved
silence-do-good
force-pushed
the
RemoveFrameBufferHandle
branch
2 times, most recently
from
dfdc73e to
c855d25
Compare
gapic/src/main/com/google/gapid/perfetto/views/SliceSelectionView.java
Outdated
Show resolved
Hide resolved
gapic/src/main/com/google/gapid/perfetto/views/SliceSelectionView.java
Outdated
Show resolved
Hide resolved
| private final String table; | ||
| private final long trackId; | ||
| protected final String table; | ||
| protected final long trackId; |
There was a problem hiding this comment.
Yes, let's not impose arbitrary ordering.
gapic/src/main/com/google/gapid/perfetto/views/SliceSelectionView.java
Outdated
Show resolved
Hide resolved
gapic/src/main/com/google/gapid/perfetto/views/SliceSelectionView.java
Outdated
Show resolved
Hide resolved
| } | ||
| } | ||
|
|
||
| public static class RenderStageInfo { |
There was a problem hiding this comment.
I know you've been going the rounds about this name, so ignore this if you are tired of renaming this:
I don't like the name "Render Stages". It's not standard. We should call it VulkanInfo or maybe ApiInfo. Definitely change the label in the UI to not mention "Render Stages".
There was a problem hiding this comment.
Changed it to Vulkan Info in the UI for now.. Leaving the class name as is and can be changed later.
The debug markers are now direct fields in the gpu_slice table and this requires some UI changes to be shown properly. Bug: 140590067
silence-do-good
force-pushed
the
RemoveFrameBufferHandle
branch
from
c855d25 to
a32810d
Compare
| @@ -163,7 +163,7 @@ def gapid_dependencies(android = True, mingw = True, locals = {}): | |||
| name = "perfetto", | |||
| locals = locals, | |||
| remote = "https://android.googlesource.com/platform/external/perfetto", | |||
| commit = "975bbd74e6b1d7da8dbdaaeec9191fb28471ed2c", | |||
| commit = "15c8c3e5af6e843dfcaf036333b7ccdfbb1b725f", | |||
There was a problem hiding this comment.
Please also update the shallow_since, so it doesn't warn on builds.
There was a problem hiding this comment.
I'll update it separately in a different patch as I'm not sure how to do it. I'm merging this now since stellama is blocked on this and needs the patch urgently.
…ane (google#3697) Update Perfetto & UI to show vulkan debug markers in selection view The debug markers are now direct fields in the gpu_slice table and this requires some UI changes to be shown properly. Bug: 140590067
The debug markers are now direct fields in the gpu_slice table and this
requires some UI changes to be shown properly.
Bug: 140590067