Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added some Vulkan documentation #3

Merged
merged 1 commit into from
Mar 4, 2017
Merged

Added some Vulkan documentation #3

merged 1 commit into from
Mar 4, 2017

Conversation

AWoloszyn
Copy link
Contributor

No description provided.

README.md Outdated
@@ -5,6 +5,7 @@ GAPID is a collection of tools that allows you to inspect, tweak and replay call
## Status
GAPID is still in development but already can be used to debug many Android OpenGL ES and Vulkan applications.
Downloadable prebuilts will be available once the project reaches beta quality.
Vulkan is still a work in progress. Current status can be found [here](docs/vulkan.md)
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Need . to end the sentence.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Done

docs/vulkan.md Outdated
@@ -0,0 +1,183 @@
# Vulkan Status

# Trace and Replay
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

These should be sections starting with ##.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Done

docs/vulkan.md Outdated

| Command Name | Capture | Mid-Execution |
|-------------------------------------------------------|:-------:|:-------------:|
| vkAllocateCommandBuffers | [x] | [x] |
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The [x] and [] don't appear to render as anything special in the code-review preview. Is this a preview bug, or are you just going for text?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

In lists they show up as check-boxes, but they dont when in a table I guess. I have switched this to use check-mark emojis.

@@ -5,6 +5,7 @@ GAPID is a collection of tools that allows you to inspect, tweak and replay call
## Status
GAPID is still in development but already can be used to debug many Android OpenGL ES and Vulkan applications.
Downloadable prebuilts will be available once the project reaches beta quality.
Vulkan is still a work in progress. Current status can be found [here](docs/vulkan.md).

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Vulkan is still a work in progress.

So is GLES and GAPID as a whole (as mentioned 2 lines up). Perhaps:

Vulkan support is described in detail [here](docs/vulkan.md).

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Not sure if you saw this comment, but I'm going to merge anyway - this is minor.

@ben-clayton ben-clayton merged commit b78483f into master Mar 4, 2017
@ben-clayton ben-clayton deleted the vulkan-docs branch March 4, 2017 17:11
pmuetschard pushed a commit that referenced this pull request Jun 11, 2020
 - Add drag-selection to the Process Panel.
 - Change CPU slices' color after drag-selecting in Thread Panel.
 - Bug: http://b/147922469. #2 and #3.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants