Don't rely on context cancelation to release a Vulkan device. #2628
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
A simple type alias to make it clear what the returned function is for, as well as some simple utilities to make using cleanup functions a bit more expressive.
This is an old bug that got exasperated recently. The context was never cancelled if the trace "finished" on its own - i.e. it was bounded by the number of frames captures or the app exited/crashed. Recently, a user request to stop tracing was also changed to not cancel the context either, causing the device to be released even less often. (It appears the context may sometimes get cancelled on gapis exit.) Fixes google#2622
AWoloszyn
approved these changes
Feb 27, 2019
pau-baiget
approved these changes
Feb 27, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is an old bug that got exasperated recently. The context was never cancelled if the trace "finished" on its own - i.e. it was bounded by the number of frames captures or the app exited/crashed. Recently, a user request to stop tracing was also changed to not cancel the context either, causing the device to be released even less often. (It appears the context may sometimes get cancelled on gapis exit.)
Fixes #2622