Check the aspect against the image. #2601
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
We were not checking that the aspect existed before dereferencing it.
Qining
approved these changes
Feb 11, 2019
pmuetschard
reviewed
Feb 11, 2019
| @@ -232,6 +232,7 @@ sub void accessImageSubresourceSlice(ref!ImageObject image, VkImageSubresourceRa | |||
| case VK_IMAGE_ASPECT_STENCIL_BIT: | |||
| as!u64(1) | |||
| } | |||
| if !aspectBit in image.Aspects { vkErrorInvalidImageAspect(image.VulkanHandle, aspectBit) } else { | |||
There was a problem hiding this comment.
Is this really a syntax format pattern we are using? or are you just trying to avoid lots of whitespace changes?
There was a problem hiding this comment.
We have used this in a few places.
Since we don't have early-returns, we have been putting anything that behaves like an early-return like this (in the vulkan api files). Ideally I want
if !aspectBit in image.Aspecs { return; }
Otherwise we would have insane amounts of nesting, that does not help readability at all
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We were not checking that the aspect existed before dereferencing it.