gapit dump_resources: include shader type in file extension #2554
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
AWoloszyn
reviewed
Jan 21, 2019
There was a problem hiding this comment.
The only thing that may be a bit weird is
.SpirvBinary
.Spirv
As these may not be as obvious to users as we would like. I wonder if we just want to add an "Extension" field to the proto, then we can use the glslang types
.vert, .frag, .tessc, .tesse, .geom, .comp
And then
.spv (binary) .spvasm (text)
paulthomson
force-pushed
the
dump_shaders_type
branch
from
5a102f3 to
8e2b827
Compare
|
OK I have done this (although I did not modify protos) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It can be useful to know the type of dumped shaders. This simple change adds the type as an extension. E.g. "Shader<2><125>.Fragment".