Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add a @gapic_third_party indirection to the gapic build. #2447

Merged
merged 1 commit into from
Dec 12, 2018

Conversation

pmuetschard
Copy link
Member

Makes overriding of where the gapic dependencies come from a bit easier.

@pmuetschard
Copy link
Member Author

Let me know if this helps with the maven deps.

@Qining
Copy link
Contributor

Qining commented Dec 11, 2018

hmm, I don't know if this will be helpful. Generally what I have to do is manually downloading all the dependencies, then create local_repository for them. As all the dependencies in GAPID are wrapped with maybe_repository, those already existing dependencies won't be pulled again. This is also the approach we have always been using.

In this way, for most dependencies, the BUILD file and WORKSPACE file will also have their local copies, so the package structure won't change.

@pmuetschard
Copy link
Member Author

Well, the point of this change is that you no longer have to do that! You now have lots of options:

  1. Create one extra repository called "gapic_third_party" that contains the 6 third party targets we need (:grpc, :okhttp, :lwjgl, :guava, :jface and :swt).
  2. Check the jars into your main repo and then in the WORKSPACE file call the gapic_third_party function with the mappings pointing to them and it will generate the gapic_third_party repo BUILD file for you.
  3. With the mappings you can have the jars almost anywhere.
  4. ...

@Qining
Copy link
Contributor

Qining commented Dec 11, 2018

Great, thanks, this definitely helps a lot.

Makes overriding of where the gapic dependencies come from a bit easier.
@pmuetschard pmuetschard merged commit 6aeaba0 into google:master Dec 12, 2018
@pmuetschard pmuetschard deleted the gapic_tp branch December 12, 2018 21:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants