Limit the size of replay resource data chunks to reduce memory usage #2171
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
AWoloszyn
approved these changes
Sep 4, 2018
This change can reduce the memory usage a bit as grpc's copies of the resource data are smaller than before, limit of 100MB in practice should be large enough to not hurt data transferring performance.
Qining
force-pushed
the
limit-res-chunk-size
branch
from
1a9f3bc to
48182b5
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This change can reduce the memory usage a bit as grpc's copies of the
resource data are smaller than before, limit of 100MB in practice should
be large enough to not hurt data transferring performance.