Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Workaround an issue in golang 1.10.3 where a 4GB file is truncated. #2141

Merged
merged 1 commit into from
Aug 20, 2018

Conversation

AWoloszyn
Copy link
Contributor

Copy link
Contributor

@ben-clayton ben-clayton left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is there a golang bug created?
Can we have some comments in here explaining what's going on? Perhaps move the hack out to a separate function and have it documented?

@AWoloszyn
Copy link
Contributor Author

The golang was in the first comment. (As well as commit comment).
I can move this out.

@AWoloszyn AWoloszyn merged commit 50a31c1 into google:master Aug 20, 2018
@AWoloszyn AWoloszyn deleted the workaround-go branch August 20, 2018 19:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants