Bunch of UI Polish for the New Trace Dialog #2105
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The scrubber de-registered itself too early from thumbnail events and was thus not updating the images when the thumbnail change event was broadcast.
- Move the label gen into the model, so it can be re-used. - Show the OS kind along with the name (version). - Show the GPU kind - Serials can be empty, don't show an extra `-` in that case.
The WaitingToStart status is used to signal that the trace is ready to capture frames and is waiting for the user to start the trace (or the "start frame" to arrive). This status is currently erroneously returned a single time, when an MEC trace starts, followed by Initializing n-times, and then WaitingToStart again.
- Don't attempt to open failed traces. - Better button labels and handling. - Better status labels.
If the model name and/or manufacturer is available, use them to form the device hardware name: e.g "Google Pixel" instead of "sailfish".
ben-clayton
approved these changes
Jul 30, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
... and other UI things.