Don't merge stdout/stderr on remote device-info. #2102
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ben-clayton
approved these changes
Jul 30, 2018
ben-clayton
approved these changes
Jul 31, 2018
core/os/device/remotessh/commands.go
Outdated
| @@ -185,8 +186,16 @@ func (b binding) PushFile(ctx context.Context, source, dest string) error { | |||
| if err != nil { | |||
| return err | |||
| } | |||
| mode := permission.Mode() | |||
| // If we are on windows pushing to Linux, we lose the executable | |||
| // bit, geti t back. | |||
If the remote device-info produces stderr output, but does not fail, we should log it, but not try to parse it as json. Also clean up some minor issues with Windows->Linux remote.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If the remote device-info produces stderr output, but does not
fail, we should log it, but not try to parse it as json.