Add context destruction blacklist. #1869
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This works around: |
ben-clayton
approved these changes
May 7, 2018
| @@ -160,7 +160,17 @@ void buildDeviceInstance(const query::Option& opt, void* platform_data, | |||
| instance->set_allocated_configuration(configuration); | |||
| deviceInstanceID(instance); | |||
|
|
|||
| query::destroyContext(); | |||
| // Blacklist of OS/Hardware version that mean we cannot safely | |||
There was a problem hiding this comment.
s/mean/means
Link to bug in comment?
This will cause a context and window leak, which is bad, but only for certain hardware combinations. We can remove once we figure out exactly waht is causing this behavior.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This will cause a context and window leak, which is bad, but
only for certain hardware combinations.
We can remove once we figure out exactly waht is causing
this behavior.