Remap the allocator during replay. #1837
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ben-clayton
reviewed
Apr 26, 2018
gapis/api/vulkan/api/types.api
Outdated
| @@ -73,3 +73,4 @@ type u32 VkSampleMask | |||
| // Vulkan 1.1 core | |||
| @replay_remap @nonDispatchHandle type u64 VkDescriptorUpdateTemplate | |||
| @replay_remap @nonDispatchHandle type u64 VkSamplerYcbcrConversion | |||
| @replay_custom_value type const VkAllocationCallbacks* AllocationCallbacks | |||
There was a problem hiding this comment.
Looks like you've put this under Vulkan 1.1, when this is a Vulkan 1.0 thing?
ben-clayton
reviewed
Apr 26, 2018
gapis/api/vulkan/custom_replay.go
Outdated
| @@ -452,3 +453,7 @@ func (a *ReplayAllocateImageMemory) Mutate(ctx context.Context, id api.CmdID, s | |||
| a.PMemory.Slice(0, 1, l).Write(ctx, []VkDeviceMemory{memory}, a, s, b) | |||
| return err | |||
| } | |||
|
|
|||
| func (i AllocationCallbacks) value(b *builder.Builder, cmd api.Cmd, s *api.GlobalState) value.Value { | |||
| return value.AbsolutePointer(0) | |||
There was a problem hiding this comment.
Please comment why you're always using a 0.
ben-clayton
approved these changes
Apr 26, 2018
This means we can replace pAllocator with nulltpr when necessary.
AWoloszyn
force-pushed
the
remove-allocator
branch
from
eb455b5 to
68b1f6a
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This means we can replace pAllocator with nulltpr when
necessary.