Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

gapis/api/gles: Fix panic when calling DataTypeSize(GL_INT) #1738

Merged
merged 1 commit into from
Mar 12, 2018
Merged

gapis/api/gles: Fix panic when calling DataTypeSize(GL_INT) #1738

merged 1 commit into from
Mar 12, 2018

Conversation

ben-clayton
Copy link
Contributor

Rename the file, and refactor another place we were calculating type size.

@ben-clayton ben-clayton requested a review from pmuetschard March 9, 2018 17:08
pmuetschard
pmuetschard requested changes Mar 9, 2018
View reviewed changes
Copy link
Member

@pmuetschard pmuetschard left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This fails to build. I'm fairly certain the presubmit failures are real.

@ben-clayton
gapis/api/gles: Fix panic when calling DataTypeSize(GL_INT)
4a19f18 
Rename the file, and refactor another place we were calculating type size.
@ben-clayton
Copy link
Contributor Author

Now all fixed

@ben-clayton ben-clayton merged commit 4830f68 into google:master Mar 12, 2018
@ben-clayton ben-clayton deleted the fix-1703 branch March 12, 2018 16:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@pmuetschard pmuetschard pmuetschard approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@ben-clayton @pmuetschard