Handle GL_MAX_VIEWS_OVR in glGetInteger #1583
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ben-clayton
approved these changes
Feb 3, 2018
gapis/api/gles/api/state_queries.api
Outdated
| @@ -1006,6 +1006,10 @@ sub void GetStateVariable!T(GLenum name, bool isIndexed, GLuint index, T* v) { | |||
| case GL_MAX_VERTEX_UNIFORM_VECTORS: { | |||
| v[0] = as!T(ctx.Constants.MaxVertexUniformVectors) | |||
| } | |||
| @if(Extension.GL_OVR_multiview) | |||
| case GL_MAX_VIEWS_OVR: { | |||
| write(v[0:1]) | |||
There was a problem hiding this comment.
If we don't have a constant for this that can be assigned out, please add a TODO to add one.
There was a problem hiding this comment.
I've added the constant. PTAL.
ben-clayton
reviewed
Mar 1, 2018
| @@ -175,6 +175,7 @@ func DefaultConstants30() Constants { | |||
| MaxTransformFeedbackSeparateAttribs: 4, | |||
| MaxTransformFeedbackSeparateComponents: 4, | |||
| MaxTextureMaxAnisotropyExt: 2.0, | |||
| MaxViewsExt: 2, | |||
There was a problem hiding this comment.
Maybe this should default to 1?
There was a problem hiding this comment.
No, the minimum is 2.
ben-clayton
approved these changes
Mar 1, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.