Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Vulkan: vkDestroyImage loops over all image views #2457

Closed
bjoeris opened this issue Dec 13, 2018 · 0 comments
Closed

Vulkan: vkDestroyImage loops over all image views #2457

bjoeris opened this issue Dec 13, 2018 · 0 comments
Assignees
@bjoeris

Comments

@bjoeris
Copy link
Contributor

bjoeris commented Dec 13, 2018

This loop is only looking for image views derived from the image being destroyed, so this is inefficient, and additionally causes spurious dependencies from vkDestroyImage to every image view (and hence every image).
@bjoeris bjoeris self-assigned this Dec 13, 2018
bjoeris added a commit to bjoeris/gapid that referenced this issue Dec 13, 2018
@bjoeris
Vulkan: Added Views field to ImageObject to store image views
ac37351 
This means vkDestroyImage no longer needs to loop over all image views to find
the views of the image being destroyed.

This change breaks compatibility with old captures.

Fixes google#2457
bjoeris added a commit to bjoeris/gapid that referenced this issue Dec 14, 2018
@bjoeris
Vulkan: Added Views field to ImageObject to store image views
aa891a5 
This means vkDestroyImage no longer needs to loop over all image views to find
the views of the image being destroyed.

This change breaks compatibility with old captures.

Fixes google#2457
@bjoeris bjoeris mentioned this issue Dec 14, 2018
Merged
bjoeris added a commit that referenced this issue Dec 14, 2018
@bjoeris
Vulkan: Added Views field to ImageObject to store image views
70d8626 
This means vkDestroyImage no longer needs to loop over all image views to find
the views of the image being destroyed.

This change breaks compatibility with old captures.

Fixes #2457
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@bjoeris bjoeris

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@bjoeris