Skip to content

Commit

Permalink
Update from some comments
Browse files Browse the repository at this point in the history
  • Loading branch information
AWoloszyn committed Feb 5, 2018
1 parent 6137e46 commit efe51a5
Show file tree
Hide file tree
Showing 3 changed files with 4 additions and 3 deletions.
1 change: 0 additions & 1 deletion gapii/cc/chunk_writer.cpp
Original file line number Diff line number Diff line change
Expand Up @@ -70,7 +70,6 @@ bool ChunkWriterImpl::write(std::string& s) {

void ChunkWriterImpl::flush() {
size_t bufferSize = mBuffer.size();
// If we flush en empty buffer, this will return false, which is incorrect.
mStreamGood = mWriter->write(mBuffer.data(), mBuffer.size()) == bufferSize;
mBuffer.clear();
}
Expand Down
4 changes: 2 additions & 2 deletions gapii/cc/pool.h
Original file line number Diff line number Diff line change
Expand Up @@ -25,8 +25,8 @@ namespace gapii {
class Pool {
public:
static std::shared_ptr<Pool> create(uint32_t id, uint64_t size);
// This creates a pool that can be serialized, but has no actual
// backing memory
// This creates a pool that can be serialized, but has no actual
// backing memory
static std::shared_ptr<Pool> create_virtual(uint32_t id, uint64_t size);

~Pool();
Expand Down
2 changes: 2 additions & 0 deletions gapis/api/vulkan/vulkan.go
Original file line number Diff line number Diff line change
Expand Up @@ -75,6 +75,8 @@ func (*State) Root(ctx context.Context, p *path.State) (path.Node, error) {
return p, nil
}

// SetupInitialState recreates the command lamdas from the state block.
// These are not encoded so we have to set them up here.
func (c *State) SetupInitialState(ctx context.Context) {
for _, b := range *c.CommandBuffers.Map {
for _, v := range b.CommandReferences.KeysSorted() {
Expand Down

0 comments on commit efe51a5

Please sign in to comment.