Don't close the connection from the heartbeat if it's already closing.

google · Dec 20, 2018 · c1a39d8 · c1a39d8
1 parent 0b091e6
commit c1a39d8
Showing 1 changed file with 1 addition and 1 deletion.
diff --git a/gapir/client/session.go b/gapir/client/session.go
@@ -394,7 +394,6 @@ func (s *session) ping(ctx context.Context) (time.Duration, error) {
 }
 
 func (s *session) heartbeat(ctx context.Context, pingInterval time.Duration) {
-	defer s.close()
 	for {
 		select {
 		case <-task.ShouldStop(ctx):
@@ -403,6 +402,7 @@ func (s *session) heartbeat(ctx context.Context, pingInterval time.Duration) {
 			_, err := s.ping(ctx)
 			if err != nil {
 				log.E(ctx, "Error sending keep-alive ping. Error: %v", err)
+				s.close(ctx)
 				return
 			}
 		}