Optimize byte slice copies

google · May 25, 2018 · 9763afa · 9763afa
1 parent 4392580
commit 9763afa
Showing 1 changed file with 8 additions and 4 deletions.
diff --git a/gapis/api/templates/api.go.tmpl b/gapis/api/templates/api.go.tmpl
@@ -628,11 +628,15 @@ import (
     func (s {{$slice_ty}}) Read(ϟctx context.Context, ϟc ϟapi.Cmd, ϟg *ϟapi.GlobalState, ϟb *builder.Builder) ([]{{$el_ty}}, error) {
       ϟa := ϟg.Arena; _ = ϟa
       s.OnRead(ϟctx, ϟc, ϟg, ϟb)
-      ϟd := s.Decoder(ϟctx, ϟg)
       out := make([]{{$el_ty}}, s.count)
-      for i := range out {
-        out[i] = {{Template "Go.Decode" $s.To}}
-      }
+      ϟd := s.Decoder(ϟctx, ϟg)
+      {{if IsU8 $s.To}}
+        ϟd.Data(out)
+      {{else}}
+        for i := range out {
+          out[i] = {{Template "Go.Decode" $s.To}}
+        }
+      {{end}}
       if err := ϟd.Error(); err != nil {
         return nil, err
       }