Skip to content

Commit

Permalink
Show a warning when doing MEC for GLES.
Browse files Browse the repository at this point in the history
  • Loading branch information
pmuetschard committed Jun 28, 2018
1 parent 5288ce5 commit 0a64725
Showing 1 changed file with 15 additions and 1 deletion.
16 changes: 15 additions & 1 deletion gapic/src/main/com/google/gapid/views/TracerDialog.java
Original file line number Diff line number Diff line change
Expand Up @@ -257,6 +257,7 @@ private abstract static class SharedTraceInput extends Composite {
private static final String DEFAULT_TRACE_FILE = "trace";
private static final String TRACE_EXTENSION = ".gfxtrace";
private static final DateFormat TRACE_DATE_FORMAT = new SimpleDateFormat("_yyyyMMdd_HHmm");
protected static final String MEC_LABEL = "Trace From Beginning";

private final String date = TRACE_DATE_FORMAT.format(new Date());
protected final ComboViewer api;
Expand Down Expand Up @@ -302,7 +303,7 @@ protected void configureDialog(DirectoryDialog dialog) {

createLabel(this, "");
fromBeginning = withLayoutData(
createCheckbox(this, "Trace From Beginning", !models.settings.traceMidExecution),
createCheckbox(this, MEC_LABEL, !models.settings.traceMidExecution),
new GridData(SWT.FILL, SWT.FILL, true, false));

createLabel(this, "");
Expand Down Expand Up @@ -377,6 +378,8 @@ private File getOutputFile() {
}

private static class AndroidInput extends SharedTraceInput {
private static final String MEC_WARNING = "(mid-execution capture for GLES is experimental)";

private final Runnable refreshDevices;
private ComboViewer device;
private LoadingIndicator.Widget deviceLoader;
Expand Down Expand Up @@ -440,6 +443,17 @@ public AndroidInput(
traceTarget.addBoxListener(SWT.Modify, targetListener);
targetListener.handleEvent(null);

Listener mecListener = e -> {
if (getSelectedApi() == Tracer.Api.Vulkan || fromBeginning.getSelection()) {
fromBeginning.setText(MEC_LABEL);
} else {
fromBeginning.setText(MEC_LABEL + " " + MEC_WARNING);
}
};
api.getCombo().addListener(SWT.Selection, mecListener);
fromBeginning.addListener(SWT.Selection, mecListener);
mecListener.handleEvent(null);

disablePcs.addListener(
SWT.Selection, e -> pcsWarning.setVisible(!disablePcs.getSelection()));
}
Expand Down

0 comments on commit 0a64725

Please sign in to comment.