[nnx] fix nanobind #4413
Open
[nnx] fix nanobind #4413
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cgarciae
force-pushed
the
nnx-optimizations-p3
branch
from
1da88f8 to
6c135f7
Compare
cgarciae
force-pushed
the
nnx-optimizations-p4
branch
10 times, most recently
from
cafa8c7 to
f19b1a8
Compare
cgarciae
force-pushed
the
nnx-optimizations-p3
branch
from
6c135f7 to
9578456
Compare
cgarciae
force-pushed
the
nnx-optimizations-p4
branch
from
f19b1a8 to
cf8fbfc
Compare
IvyZX
approved these changes
Dec 2, 2024
tests/flaxlib_test.py
Outdated
| @@ -15,11 +15,10 @@ | |||
|
|
|||
| # TODO: Re-enable this test after setting up CI build for flaxlib CC. | |||
There was a problem hiding this comment.
Remove this line please, thanks!
There was a problem hiding this comment.
removed the entire file
cgarciae
force-pushed
the
nnx-optimizations-p4
branch
4 times, most recently
from
6258bc9 to
32bbddf
Compare
cgarciae
force-pushed
the
nnx-optimizations-p4
branch
from
32bbddf to
9f2ef36
Compare
|
Check out this pull request on See visual diffs & provide feedback on Jupyter Notebooks. Powered by ReviewNB |
cgarciae
force-pushed
the
nnx-optimizations-p4
branch
7 times, most recently
from
6ed8dac to
d088e18
Compare
cgarciae
force-pushed
the
nnx-optimizations-p4
branch
from
d088e18 to
c7d0756
Compare
cgarciae
force-pushed
the
nnx-optimizations-p4
branch
9 times, most recently
from
e7b8a0d to
8241d18
Compare
cgarciae
force-pushed
the
nnx-optimizations-p4
branch
from
8241d18 to
9ef4814
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
scikit_build_core.buildfor packaging as detailed in: https://nanobind.readthedocs.io/en/latest/packaging.html_graph_flattenand some helper types.