Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[nnx] optimize NodeDef.attributes #4399

Merged
merged 1 commit into from
Nov 26, 2024
Merged

Conversation

cgarciae
Copy link
Collaborator

@cgarciae cgarciae commented Nov 26, 2024

What does this PR do?

python benchmarks/nnx_graph_overhead.py --mode=all --depth=100 --total_steps=1000

### NNX ###
total time: 7.961960315704346
time per step: 7961.96 µs
time per layer: 79.62 µs

### JAX ###
total time: 1.789884328842163
time per step: 1789.88 µs
time per layer: 17.90 µs

@cgarciae cgarciae force-pushed the nnx-more-optimizations branch from 4d7b74f to 092fa8c Compare November 26, 2024 02:41
Copy link

Check out this pull request on  ReviewNB

See visual diffs & provide feedback on Jupyter Notebooks.


Powered by ReviewNB

Base automatically changed from nnx-performance-guide to main November 26, 2024 08:30
@cgarciae cgarciae force-pushed the nnx-more-optimizations branch 2 times, most recently from def5abc to fd326f4 Compare November 26, 2024 14:19
@cgarciae cgarciae force-pushed the nnx-more-optimizations branch from fd326f4 to 861936f Compare November 26, 2024 18:36
@copybara-service copybara-service bot merged commit fe8fb59 into main Nov 26, 2024
19 checks passed
@copybara-service copybara-service bot deleted the nnx-more-optimizations branch November 26, 2024 21:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants