Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[nnx] improve init_cache docs #4291

Merged
merged 1 commit into from
Oct 23, 2024
Merged

[nnx] improve init_cache docs #4291

merged 1 commit into from
Oct 23, 2024

Conversation

cgarciae
Copy link
Collaborator

@cgarciae cgarciae commented Oct 12, 2024 •
edited
Loading

What does this PR do?

Fixes #4290.

8bitmp3
8bitmp3 approved these changes Oct 23, 2024
View reviewed changes
Copy link
Collaborator

@8bitmp3 8bitmp3 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@cgarciae LGTM.

Checked the new code, it throws ValueError: Autoregressive cache not initialized, call ``init_cache`` first. as expected ("throws an error because cache isn't initialized").

@IvyZX @levskaya PTAL if a second LGTM is needed.

@8bitmp3 8bitmp3 requested review from levskaya and IvyZX October 23, 2024 19:58
@copybara-service copybara-service bot merged commit 3f3c03b into main Oct 23, 2024
19 checks passed
@copybara-service copybara-service bot deleted the init-cache-docs branch October 23, 2024 20:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@8bitmp3 8bitmp3 8bitmp3 approved these changes

@IvyZX IvyZX IvyZX approved these changes

@levskaya levskaya Awaiting requested review from levskaya

Assignees

@levskaya levskaya

@IvyZX IvyZX

@8bitmp3 8bitmp3

Labels
pull ready
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@cgarciae @IvyZX @8bitmp3 @levskaya