Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update to Flax NNX MNIST tutorial #4277

Merged
merged 1 commit into from
Oct 10, 2024
Merged

Update to Flax NNX MNIST tutorial #4277

merged 1 commit into from
Oct 10, 2024

Conversation

8bitmp3
Copy link
Collaborator

@8bitmp3 8bitmp3 commented Oct 9, 2024 •
edited
Loading

@8bitmp3 8bitmp3 requested review from cgarciae, IvyZX and chiamp October 9, 2024 16:53
@8bitmp3 8bitmp3 self-assigned this Oct 9, 2024
@review-notebook-app Review Notebook App
Copy link

Check out this pull request on  ReviewNB

See visual diffs & provide feedback on Jupyter Notebooks.

Powered by ReviewNB

@8bitmp3 8bitmp3 removed the request for review from chiamp October 9, 2024 16:53
IvyZX
IvyZX approved these changes Oct 9, 2024
View reviewed changes
Copy link
Collaborator

@IvyZX IvyZX left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great work! Just some nits. Feel free to add pull-ready label when you made the change!

docs_nnx/mnist_tutorial.ipynb Outdated Show resolved Hide resolved
docs_nnx/mnist_tutorial.ipynb Outdated Show resolved Hide resolved
@copybara-service copybara-service bot merged commit f425c2f into google:main Oct 10, 2024
17 checks passed
@8bitmp3 8bitmp3 deleted the update-mnist branch October 10, 2024 11:59
@8bitmp3
Copy link
Collaborator Author

8bitmp3 commented Oct 10, 2024

thank you @cgarciae and @IvyZX

@8bitmp3 8bitmp3 changed the title Light update to Flax NNX MNIST tutorial Update to Flax NNX MNIST tutorial Oct 11, 2024
@IvyZX IvyZX mentioned this pull request Oct 15, 2024
Closed
4 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@IvyZX IvyZX IvyZX approved these changes

@cgarciae cgarciae cgarciae approved these changes

Assignees

@8bitmp3 8bitmp3

Labels
pull ready
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@8bitmp3 @cgarciae @IvyZX