Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update to Flax NNX Model Surgery #4276

Merged
merged 2 commits into from
Oct 10, 2024

Conversation

8bitmp3
Copy link
Collaborator

@8bitmp3 8bitmp3 commented Oct 9, 2024

Copy link

Check out this pull request on  ReviewNB

See visual diffs & provide feedback on Jupyter Notebooks.


Powered by ReviewNB

@8bitmp3 8bitmp3 requested review from IvyZX and cgarciae October 9, 2024 16:16
@8bitmp3 8bitmp3 self-assigned this Oct 9, 2024
@8bitmp3 8bitmp3 force-pushed the update-model-surgery branch from 6929786 to 8ca8131 Compare October 9, 2024 16:18
Copy link
Collaborator

@IvyZX IvyZX left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you! Just some nits.

docs_nnx/guides/surgery.ipynb Outdated Show resolved Hide resolved
docs_nnx/guides/surgery.ipynb Outdated Show resolved Hide resolved
docs_nnx/guides/surgery.ipynb Outdated Show resolved Hide resolved
docs_nnx/guides/surgery.ipynb Outdated Show resolved Hide resolved
@copybara-service copybara-service bot merged commit 8a4d6d6 into google:main Oct 10, 2024
17 checks passed
@8bitmp3 8bitmp3 deleted the update-model-surgery branch October 11, 2024 22:22
@8bitmp3 8bitmp3 changed the title Light update to Flax NNX Model Surgery Update to Flax NNX Model Surgery Oct 11, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants