Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update Flax NNX Scale Up SPMD guide #4239

Merged
merged 1 commit into from
Oct 3, 2024

Conversation

8bitmp3
Copy link
Collaborator

@8bitmp3 8bitmp3 commented Oct 1, 2024

No description provided.

Copy link

Check out this pull request on  ReviewNB

See visual diffs & provide feedback on Jupyter Notebooks.


Powered by ReviewNB

Copy link
Collaborator

@IvyZX IvyZX left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the proofread! Approved - just a few nits.

docs_nnx/guides/flax_gspmd.md Outdated Show resolved Hide resolved
docs_nnx/guides/flax_gspmd.md Outdated Show resolved Hide resolved
docs_nnx/guides/flax_gspmd.md Outdated Show resolved Hide resolved
docs_nnx/guides/flax_gspmd.md Outdated Show resolved Hide resolved
@8bitmp3 8bitmp3 force-pushed the upgrade-nnx-scale-up branch from 9b9b866 to ab6fef5 Compare October 3, 2024 17:41
@8bitmp3 8bitmp3 force-pushed the upgrade-nnx-scale-up branch from ab6fef5 to 2bf7f9d Compare October 3, 2024 20:11
@copybara-service copybara-service bot merged commit 7c5afdb into google:main Oct 3, 2024
18 checks passed
@8bitmp3 8bitmp3 deleted the upgrade-nnx-scale-up branch October 6, 2024 17:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants