Make orbax an optional dependency #2882
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The issue is orbax itself depends on flax. So, we have a cycle dependency between packages. Despite that the cycle is not that harmful (pip install flax and orbax without any issues), it is better to untie cycle in order to avoid any possible edge cases.
|
We are working actively with Orbax to decouple the dependency: #2707 A solution should be out soon for Orbax to remove its dependency on Flax. |
|
Is there a reason not to merge this PR? IIUC it would resolve #2707 |
|
@samuela I guess, it's stale. Orbax maintainers manages dependencies and split |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The issue is
orbaxitself depends onflax. So, we have a cycle dependency between packages. Despite that the cycle is not that harmful (pip install flax andorbaxwithout any issues), it is better to untie cycle in order to avoid any possible edge cases in package dependency resolution.