-
Notifications
You must be signed in to change notification settings - Fork 3.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
dart: Fix incorrect write in Float64 write method #8290
Conversation
Thanks for your pull request! It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA). View this failed invocation of the CLA check for more information. For the most up to date status, view the checks section at the bottom of the pull request. |
Hi Llamadmiral, I attributed the commit to you because you have found the fix for it. For this to get merged with your handle in the credit, you need to sign the CLA! |
Hello @NotTsunami, Thanks for attributing the commit to me! I signed the CLA, and pressed rescan, I think it finished successfully. Thanks again! :) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, thanks a lot!
any chance you could prepare a changelog entry for the future release?
diff --git a/dart/CHANGELOG.md b/dart/CHANGELOG.md
index 95629209..2061b830 100644
--- a/dart/CHANGELOG.md
+++ b/dart/CHANGELOG.md
@@ -1,5 +1,9 @@
# Changelog
+## Unreleased
+
+- ..... (#8290)
+
## 23.5.26
- omit type annotationes for local variables (#7067, #7069, #7070)
Co-authored-by: Llamadmiral <[email protected]> Co-authored-by: Derek Bailey <[email protected]>
Co-authored-by: Llamadmiral <[email protected]> Co-authored-by: Derek Bailey <[email protected]>
Closes #8070, closes #6688.
Credits @Llamadmiral for pointing out the fix and @vaind for the test case.
NOTE: The currently commented out test code is still commented out as it isn't a great test case. The test will fail because no ColorT type exists (as expected). We should probably get a better test case.
flatbuffers/dart/test/flat_buffers_test.dart
Lines 818 to 827 in 7106d86