Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[C++] Allow using FLATBUFFERS_MIN_BUFFER_SIZE in other namespaces #8229

Merged
merged 2 commits into from
May 29, 2024

Conversation

dominiklohmann
Copy link
Contributor

This is a small change that makes FLATBUFFERS_MIN_BUFFER_SIZE usable outside of the flatbuffers namespace.

This is a small change that makes `FLATBUFFERS_MIN_BUFFER_SIZE` usable
outside of the `flatbuffers` namespace.
Copy link

google-cla bot commented Feb 3, 2024

Thanks for your pull request! It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

View this failed invocation of the CLA check for more information.

For the most up to date status, view the checks section at the bottom of the pull request.

@github-actions github-actions bot added the c++ label Feb 3, 2024
@dominiklohmann
Copy link
Contributor Author

I've signed the CLA and triggered the check again, seems to pass now.

@dbaileychess dbaileychess enabled auto-merge (squash) May 29, 2024 03:54
@dbaileychess
Copy link
Collaborator

Thanks!

@dbaileychess dbaileychess merged commit 58c8eb5 into google:master May 29, 2024
45 checks passed
jochenparm pushed a commit to jochenparm/flatbuffers that referenced this pull request Oct 29, 2024
…ogle#8229)

This is a small change that makes `FLATBUFFERS_MIN_BUFFER_SIZE` usable
outside of the `flatbuffers` namespace.
jochenparm pushed a commit to jochenparm/flatbuffers that referenced this pull request Oct 29, 2024
…ogle#8229)

This is a small change that makes `FLATBUFFERS_MIN_BUFFER_SIZE` usable
outside of the `flatbuffers` namespace.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants