Convert flatbuffers_version_string to inline function #7046
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
aardappel
reviewed
Jan 29, 2022
include/flatbuffers/flatbuffers.h
Outdated
| FLATBUFFERS_STRING(FLATBUFFERS_VERSION_REVISION); | ||
|
|
||
| #endif // !defined(_WIN32) && !defined(__CYGWIN__) | ||
| inline std::string flatbuffers_version_string() { |
There was a problem hiding this comment.
much like the existing function, this can return a const char *.. you can concat static strings just by placing them next to eachother. std::string often implies an allocation.
There was a problem hiding this comment.
It doesn't work when you are using FLATBUFFERS_VERSION() function return a const char *.
I guess I can just go back to concatenating all the versions numbers themselves.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Replaces #6707