Replaces //cc/testutils:proto_matchers with a more complete copy of the internal versions from the protobuf library. For more context, see: https://github.com/google/googletest/issues/1761 #177
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![copybara-service[bot]](https://avatars.githubusercontent.com/in/44061?s=60&v=4){kind=small}
copybara-service
bot
force-pushed
the
test_521847154
branch
2 times, most recently
from
414d2f1 to
ed8c5b2
Compare
copybara-service
bot
force-pushed
the
test_521847154
branch
from
ed8c5b2 to
f225dc4
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Replaces //cc/testutils:proto_matchers with a more complete copy of the internal versions from the protobuf library. For more context, see: google/googletest#1761
Most immediately, this enables polymorphic proto matching from strings.
E.g., instead of saying
MyProto expected;
ASSERT_OK(ParseTextProto("[contents]", &expected);
EXPECT_THAT(result, EqualsProto(expected));
We can now say
EXPECT_THAT(result, EqualsProto("[contents]"));