Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Moe sync #642

Closed
wants to merge 17 commits into from
Closed

Moe sync #642

wants to merge 17 commits into from

Conversation

ronshapiro
Copy link
Contributor

No description provided.

eaftan and others added 17 commits June 14, 2017 16:44
@ronshapiro
Fix false positives from FunctionalInterfaceClash.
35b4442 
If you have an inheritance chain that expands the visibility of an overridden
method, the FunctionalInterfaceClash checker may consider consider those to be
separate methods rather than overrides of the same method, causing a false
positive.

RELNOTES: None

-------------
Created by MOE: https://github.com/google/moe
MOE_MIGRATED_REVID=157045905
@cushon @ronshapiro
Automated rollback of 8a87d57.
971f4de 
*** Original change description ***

Do less path string manipulation

to avoid windows-specific issues with patch application.

RELNOTES: N/A

***

-------------
Created by MOE: https://github.com/google/moe
MOE_MIGRATED_REVID=157080648
@cushon @ronshapiro
Support all annotations named 'GuardedBy'
0c31402 
including com.android.internal.annotations.GuardedBy.

RELNOTES: Support all annotations named 'GuardedBy'

-------------
Created by MOE: https://github.com/google/moe
MOE_MIGRATED_REVID=157140444
@panhania @ronshapiro
Refactor duplicated code for finding super-method symbol to the Error…
88e39d0 
… Prone core.

RELNOTES: n/a

-------------
Created by MOE: https://github.com/google/moe
MOE_MIGRATED_REVID=157167781
@plumpy @ronshapiro
Fix docs for NamedParameters
c44ae4c 
-------------
Created by MOE: https://github.com/google/moe
MOE_MIGRATED_REVID=157171839
@nick-someone @ronshapiro
Add java.util.Optional{Double,Int,Long} and java.util.UUID to the lis…
75f7a2b 
…t of well

known immutable classes.

RELNOTES: N/A

-------------
Created by MOE: https://github.com/google/moe
MOE_MIGRATED_REVID=157233479
@panhania @ronshapiro
Add a simplified checker to warn about inconsistent overloads.
6d4472d 
RELNOTES: New checker to warn about inconsistent overloads.

-------------
Created by MOE: https://github.com/google/moe
MOE_MIGRATED_REVID=157247805
@ronshapiro
Fix ASTHelpers.hasAnnotation and Matchers.hasAnnotation to not consid…
a60e149 
…er declarations on references symbols.

"method(foo, bar)" should not match hasAnnotation("java.lang.Deprecated") even if the declaration of method is marked "@deprecated".

RELNOTES: hasAnnotation now only considers annotations on declaration trees.

-------------
Created by MOE: https://github.com/google/moe
MOE_MIGRATED_REVID=157494127
@Monnoroch @ronshapiro
Add MultimapSubject.containsExactly() and MultimapSubject.comparingVa…
3a79fd6 
…luesUsing().containsExactly() to the should have even args check.

RELNOTES:

-------------
Created by MOE: https://github.com/google/moe
MOE_MIGRATED_REVID=157619475
@epmjohnston @ronshapiro
Bug Fix: BugCheckers should *only* be instantiated by ScannerSupplier…
3215c1c 
…, which determines whether the default constructor exists, or whether an ErrorProneFlags constructor should be invoked instead.

Tricorder's ErrorProneFindingsJavacAnalyzer was directly calling BugChecker constructors rather than allowing a ScannerSupplier to construct them. This broke when ErrorProneFlags constructors were added to the Immutable checkers, and the no-args constructors removed.

This cl adds a getter to ErrorProneScanner for a scanner's instantiated BugCheckers, so no classes outside of Error Prone have to instantiate BugCheckers themselves.

RELNOTES: N/A

-------------
Created by MOE: https://github.com/google/moe
MOE_MIGRATED_REVID=157845791
@lowasser @ronshapiro
Add a second reverification pass to placeholder methods.
f2aaa2c 
Placeholders are not generally allowed to reference variables that are bound to variables Refaster knows about but aren't passed into the placeholder method.  But this verification hadn't found when there were variables Refaster hadn't *yet* matched but would match after the placeholder.  So now, we just rerun that verification pass at the end of the match.

Bug discovered by sulku@ and mariasam@ :)

RELNOTES: fixes a subtle Refaster placeholder bug

-------------
Created by MOE: https://github.com/google/moe
MOE_MIGRATED_REVID=157862410
@nick-someone @ronshapiro
Update documentation for PackageLocation to clarify that the package …
a9cdfd7 
…path needs

to _end with_ the package.

-------------
Created by MOE: https://github.com/google/moe
MOE_MIGRATED_REVID=157864018
@nick-someone @ronshapiro
Swap IterableAndIterator{Positive,Negative}Cases, as they represent the
5f9a2ec 
opposite than in other cases.

RELNOTES: n/a

-------------
Created by MOE: https://github.com/google/moe
MOE_MIGRATED_REVID=158062600
@ronshapiro
Fix test breakage due to removal of GeneratedMessage.Builder#parseUnk…
8e7e8b4 
…nownField

method.

This is just test code that represents generated proto code. The actual content
is not meaningful for our tests.

-------------
Created by MOE: https://github.com/google/moe
MOE_MIGRATED_REVID=158293382
@ronshapiro
Updated NamedParameters to improve error message when comment doesn't…
a9c4a64 
… conform

to style and also to detect bad after-block comments. Change the suggestion to include spaces around the equals sign (the check is agnostic to spaces).

This change also removes @RequiresNamedParameters. We probably shouldn't be providing a new language feature which legitimizes an API design which should instead be refactored to improve usability.

RELNOTES: Change suggestion for NamedParameters to include spaces around the equals sign, improved errormessage and removed @RequiresNamedParameters

-------------
Created by MOE: https://github.com/google/moe
MOE_MIGRATED_REVID=158570586
@nick-someone @ronshapiro
Deprecate BugPattern.category, replacing it with a set of String tags…
92e5179 
…. These

tags can be used by tooling (including our Documentation generation) to group
BugCheckers into different buckets, and tag most of the existing warning-level
BugChecker instances.

RELNOTES: Deprecate BugPattern.category in favor of a collection of String
tags

-------------
Created by MOE: https://github.com/google/moe
MOE_MIGRATED_REVID=158733828
@ronshapiro
Edited ShortCircuitBoolean ErrorProne fix to only show one suggested …
215ee79 
…fix per

line

-------------
Created by MOE: https://github.com/google/moe
MOE_MIGRATED_REVID=158880824
@googlebot
Copy link
Collaborator

We found a Contributor License Agreement for you (the sender of this pull request), but were unable to find agreements for the commit author(s). If you authored these, maybe you used a different email address in the git commits than was used to sign the CLA (login here to double check)? If these were authored by someone else, then they will need to sign a CLA as well, and confirm that they're okay with these being contributed to Google.
In order to pass this check, please resolve this problem and have the pull request author add another comment and the bot will run again.

@ronshapiro
Copy link
Contributor Author

@googlebot both of those authors are done their internships and no longer at Google, but authored those commits while at the company

@ronshapiro
Copy link
Contributor Author

ronshapiro commented Jun 14, 2017 •
edited
Loading

@cushon @eaftan these continue to fail on AppVeyor - but maybe we should merge it anyway and fix-forward since a lot of commits are in here?

@eaftan
Copy link
Contributor

eaftan commented Jun 26, 2017

Sorry for the slow reply, @ronshapiro. I'm going to disable the failing test, then we can push the update.

@ronshapiro ronshapiro closed this Jul 5, 2017
@ronshapiro ronshapiro deleted the sync-master-06/14/2017 branch July 5, 2017 18:55
copybara-service bot pushed a commit that referenced this pull request Dec 7, 2023
@cushon
Import eisop/checker-framework from GitHub.
d8037b9 
#MIGRATION_3P_JAVA_SRC_CHECKER_FRAMEWORK_DATAFLOW__DEFAULT_SERVICE

  - c9b1e103fbe5ea1a3fc5d8e52a16c9982ed0bc76 Prep for next release by Werner Dietl <[email protected]>
  - 4f53c5bf42e357682104fd3cbf4878457d1d0e0d Extract version variable and update version (#630) by Werner Dietl <[email protected]>
  - 3c4dad383006e706dc102d4d835298e1e1e12114 Do not use `thisValue` when it is the NullType (#636) by Werner Dietl <[email protected]>
  - d7f9dabf1240e40484ce2b3c1c6e9feecaabe29c Generalize improvement of initialization type frames (#642) by Florian Lanzinger <[email protected]>
  - a7b753565fe9843d5e5f1ade6564bab68fa266e9 Update dependency commons-io:commons-io to v2.15.1 (#643) by renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>
  - 3ed0c114c3d686eadc803207640487e86d1d086e Update dependency gradle to v8.5 (#644) by renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>
  - 5c59bff87210b78a7fc7f8cd7b7372d2d7e60981 Update dependency com.amazonaws:aws-java-sdk-bom to v1.12... by renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>
  - 2170fdab53832a3b9016f200a78189c76298f87e Update dependency com.diffplug.spotless:spotless-plugin-g... by renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>
  - 8eb212555daec5323fd1f1af786092cbbbeef8a0 Update dependency io.github.classgraph:classgraph to v4.8... by renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>
  - 4c08ea3751b40620d20eb05ca85ead9a42f500f9 Update dependency org.checkerframework:stubparser to v3.2... by renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>
  - 2dee1c3763640e4bec88bc0b8a11a9f6bad1a5ea Warn about redundant null cases in switch statements and ... by Aosen Xiong <[email protected]>
  - 780fef9e0225761ba44000091a2f024a6ffbdecb typetools/checker-framework 3.41.0 release (#650) by Werner Dietl <[email protected]>
  - 9c804e41ed0f506713ac50224d2a63f2d2568dc2 Consistently spell it `JUnit` by Werner Dietl <[email protected]>
  - 9ad831a2432ad5cbf6bb1a99dff4121f4a6dc4e3 Add missing import to stub file by Werner Dietl <[email protected]>
  - 28f6b0fc670596c5943ca93e01b480429ef0a907 Remove warnings about junit-assertions.astub that do not ... by Werner Dietl <[email protected]>
  - a4c50adad5e36bc746cfabddba41b5f661da54d5 Formatting tweak by Werner Dietl <[email protected]>
  - 66bb90d7431427ed39f67d7a9899f93d430220c1 Make error keys consistent by Werner Dietl <[email protected]>
  - 6be13eba81909bedc263c6b1a9d4c3583af556b7 Simplify code, suppress Optional Checker FP, code consist... by Werner Dietl <[email protected]>
  - 011fbb759104d1277700a9e7893f435af00a5f90 Code comment formatting by Werner Dietl <[email protected]>
  - 5b60183f3d3934dcb205adfb77c729399687c9bc Fix formatting by Werner Dietl <[email protected]>
  - 13f7887e1941d0b6b18a9a9c85088e42fbb56c13 Fix error keys and warning texts by Werner Dietl <[email protected]>
  - 084ca4b52ab4d067a93ae32ea04c892ec36bf72a Fix terminology and use EISOP website by Werner Dietl <[email protected]>
  - f62005ea47ffe9bae7561d51ed9a0a2bed4f89c0 Skip try-with-resources test on Java 8 by Werner Dietl <[email protected]>
  - 97af13821ff7ed86c6b5f3740799a28d2a054608 Add a note by Werner Dietl <[email protected]>
  - c2df6d6cc48878b92970c568e5388ddafa60b60f Prep for release by Werner Dietl <[email protected]>
  - c08538fbc8e167a931cbe405614b52663a8e67be new release 3.41.0-eisop1 by Werner Dietl <[email protected]>

PiperOrigin-RevId: 588226344
@copybara-service copybara-service bot mentioned this pull request Dec 7, 2023
Merged
copybara-service bot pushed a commit that referenced this pull request Dec 7, 2023
@cushon
Import eisop/checker-framework from GitHub.
336323a 
#MIGRATION_3P_JAVA_SRC_CHECKER_FRAMEWORK_DATAFLOW__DEFAULT_SERVICE

  - c9b1e103fbe5ea1a3fc5d8e52a16c9982ed0bc76 Prep for next release by Werner Dietl <[email protected]>
  - 4f53c5bf42e357682104fd3cbf4878457d1d0e0d Extract version variable and update version (#630) by Werner Dietl <[email protected]>
  - 3c4dad383006e706dc102d4d835298e1e1e12114 Do not use `thisValue` when it is the NullType (#636) by Werner Dietl <[email protected]>
  - d7f9dabf1240e40484ce2b3c1c6e9feecaabe29c Generalize improvement of initialization type frames (#642) by Florian Lanzinger <[email protected]>
  - a7b753565fe9843d5e5f1ade6564bab68fa266e9 Update dependency commons-io:commons-io to v2.15.1 (#643) by renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>
  - 3ed0c114c3d686eadc803207640487e86d1d086e Update dependency gradle to v8.5 (#644) by renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>
  - 5c59bff87210b78a7fc7f8cd7b7372d2d7e60981 Update dependency com.amazonaws:aws-java-sdk-bom to v1.12... by renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>
  - 2170fdab53832a3b9016f200a78189c76298f87e Update dependency com.diffplug.spotless:spotless-plugin-g... by renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>
  - 8eb212555daec5323fd1f1af786092cbbbeef8a0 Update dependency io.github.classgraph:classgraph to v4.8... by renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>
  - 4c08ea3751b40620d20eb05ca85ead9a42f500f9 Update dependency org.checkerframework:stubparser to v3.2... by renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>
  - 2dee1c3763640e4bec88bc0b8a11a9f6bad1a5ea Warn about redundant null cases in switch statements and ... by Aosen Xiong <[email protected]>
  - 780fef9e0225761ba44000091a2f024a6ffbdecb typetools/checker-framework 3.41.0 release (#650) by Werner Dietl <[email protected]>
  - 9c804e41ed0f506713ac50224d2a63f2d2568dc2 Consistently spell it `JUnit` by Werner Dietl <[email protected]>
  - 9ad831a2432ad5cbf6bb1a99dff4121f4a6dc4e3 Add missing import to stub file by Werner Dietl <[email protected]>
  - 28f6b0fc670596c5943ca93e01b480429ef0a907 Remove warnings about junit-assertions.astub that do not ... by Werner Dietl <[email protected]>
  - a4c50adad5e36bc746cfabddba41b5f661da54d5 Formatting tweak by Werner Dietl <[email protected]>
  - 66bb90d7431427ed39f67d7a9899f93d430220c1 Make error keys consistent by Werner Dietl <[email protected]>
  - 6be13eba81909bedc263c6b1a9d4c3583af556b7 Simplify code, suppress Optional Checker FP, code consist... by Werner Dietl <[email protected]>
  - 011fbb759104d1277700a9e7893f435af00a5f90 Code comment formatting by Werner Dietl <[email protected]>
  - 5b60183f3d3934dcb205adfb77c729399687c9bc Fix formatting by Werner Dietl <[email protected]>
  - 13f7887e1941d0b6b18a9a9c85088e42fbb56c13 Fix error keys and warning texts by Werner Dietl <[email protected]>
  - 084ca4b52ab4d067a93ae32ea04c892ec36bf72a Fix terminology and use EISOP website by Werner Dietl <[email protected]>
  - f62005ea47ffe9bae7561d51ed9a0a2bed4f89c0 Skip try-with-resources test on Java 8 by Werner Dietl <[email protected]>
  - 97af13821ff7ed86c6b5f3740799a28d2a054608 Add a note by Werner Dietl <[email protected]>
  - c2df6d6cc48878b92970c568e5388ddafa60b60f Prep for release by Werner Dietl <[email protected]>
  - c08538fbc8e167a931cbe405614b52663a8e67be new release 3.41.0-eisop1 by Werner Dietl <[email protected]>

PiperOrigin-RevId: 588812139
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
cla: no
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
10 participants
@ronshapiro @googlebot @eaftan @cushon @panhania @plumpy @nick-someone @Monnoroch @epmjohnston @lowasser