Add support for specifying badEnclosingTypes for BadImport
via flags
#4231
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add support for specifying badEnclosingTypes for
BadImport
via flagsFollowing the discussions in #2236, this PR introduces the
BadImport:BadEnclosingTypes
flag to disallow nested types of specified enclosing type.This PR also takes the flag into account in
UnnecessarilyFullyQualified
to suggest importingEnclosingType.NestedType
when possible.For instance, when
-XepOpt:BadImport:BadEnclosingTypes=org.immutables.value.Value
is set, it would suggest the following:->
Also, it won't require suppressing
UnnecessarilyFullyQualified
in the example in #2236.Closes #2236.
Fixes #4228
FUTURE_COPYBARA_INTEGRATE_REVIEW=#4228 from hisener:halil.sener/bad-import-bad-enclosing-types 67aa36d