Prevent SuggestedFixes#renameMethod from modifying return type declaration
#4043
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rickie
approved these changes
Aug 9, 2023
Stephan202
approved these changes
Aug 9, 2023
| .addOutputLines( | ||
| "Test.java", | ||
| "class Test {", | ||
| " private Object object() {", |
There was a problem hiding this comment.
For other reviewers: before this fix Error Prone would suggest:
Suggested change
| " private Object object() {", | |
| " private object Object() {", |
cushon
requested changes
Aug 9, 2023
| for (ErrorProneToken token : methodTokens) { | ||
| if (token.kind() == TokenKind.IDENTIFIER && token.name().equals(tree.getName())) { | ||
| if (token.kind() == TokenKind.IDENTIFIER | ||
| && token.pos() > returnTypeEndPos |
There was a problem hiding this comment.
Instead of checking the token positions here, I think we might be able to adjust basePos earlier and only tokenize from after the return type. Do you see any issues with that approach?
There was a problem hiding this comment.
That's a good catch thanks! Will push a commit.
cushon
approved these changes
Aug 9, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
By ensuring the return type
IDENTIFIERtoken is not matched.