Support given for enforcing DirectInvocationOnMock : issue 3396 #3731
Conversation
|
Thanks for your pull request! It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA). View this failed invocation of the CLA check for more information. For the most up to date status, view the checks section at the bottom of the pull request. |
|
The missing CLA is from me using my work email in the commit - will fix it shortly, commit using personal email address. |
|
Still looking to get this reviewed & approved - everything should be ready, except the build does not pass as I've not been approved by a maintainer to run workflows. |
|
Just fixed number of associated issue #3396 |
RobertTheBlair
changed the title
Happy to help. Hardest part was getting corp sign-off (-; |
|
CI failed for only JDK 20 on Ubuntu, in code untouched by the branch. Fresh merge & rebase done. |
|
I should update the docs in /docs/bugpattern/DirectInvocationOnMock.md as well. |
…cing DirectInvocationOnMock : issue 3246 * Mockito supports BDDMockito, using "given" to correctly define mock behavior, instead of plain Mockito "when" * test some use cases that parallel existing cases * update bugpattern docs to note BDD/given as a supported pattern.
Done |
Support given for enforcing DirectInvocationOnMock : issue 3396 * Mockito supports BDDMockito, using "given" to correctly define mock behavior, instead of plain Mockito "when" * test some use cases that parallel existing cases --- This is my first PR for this Repo, so I'm approaching with all humbleness. My team at work saw this error prone warning show up, and 95% of the occurrences were from our use of BDD style `given` calls. Rather than ignoring the warning outright, I'd like to fix it here. Fixes #3731 FUTURE_COPYBARA_INTEGRATE_REVIEW=#3731 from RobertTheBlair:DirectInvocationOnMock-support-BDDMockito 2f555e1 PiperOrigin-RevId: 507165535
Support given for enforcing DirectInvocationOnMock : issue 3396 * Mockito supports BDDMockito, using "given" to correctly define mock behavior, instead of plain Mockito "when" * test some use cases that parallel existing cases --- This is my first PR for this Repo, so I'm approaching with all humbleness. My team at work saw this error prone warning show up, and 95% of the occurrences were from our use of BDD style `given` calls. Rather than ignoring the warning outright, I'd like to fix it here. Fixes #3731 FUTURE_COPYBARA_INTEGRATE_REVIEW=#3731 from RobertTheBlair:DirectInvocationOnMock-support-BDDMockito 2f555e1 PiperOrigin-RevId: 507165535
* Mockito supports BDDMockito, using "given" to correctly define mock behavior, instead of plain Mockito "when" * test some use cases that parallel existing cases Fixes #3731 FUTURE_COPYBARA_INTEGRATE_REVIEW=#3731 from RobertTheBlair:DirectInvocationOnMock-support-BDDMockito 2f555e1 PiperOrigin-RevId: 507165535
Support given for enforcing DirectInvocationOnMock : issue 3396
This is my first PR for this Repo, so I'm approaching with all humbleness.
My team at work saw this error prone warning show up, and 95% of the occurrences were from our use of BDD style
givencalls. Rather than ignoring the warning outright, I'd like to fix it here.