NullArgumentForNonNullParameter thrown by Error Prone #4225
Comments
|
Thanks. Most of the actual Error Prone team is OOO this week, but I wrote this check, so I'm seeing how easily I can have a look. Given how much Google's security policies discourage the use of Docker, I've been trying to see if there's a shorter path to reproducing this. I've managed to install scala and sbt, kick off |
|
In any case, this whole failure is interesting:
It looks to me like we have a symbol for which As an aside, I'm not sure that my |
|
( |
|
I realized I misspoke in my original report: The error happens when running browser tests locally, not when running the server. https://github.com/civiform/civiform/wiki/Testing#functional-browser-tests are our browser test directions (specifically But, it actually looks like I can no longer reproduce the error. Earlier today, I was working on a few different local PRs (civiform/civiform#6254, then civiform/civiform#6272 which is stacked on top) and I had one of those PR branches checked out when I started seeing the error. What I just did was:
It seems like something got temporarily mangled, but checking out main un-mangled it somehow? Since I can't repro and don't have good repro steps, feel free to close as not reproducible. |
|
Thanks. I'll see if the aforementioned real Error Prone team has any thoughts upon their return. It does seem believable that some file got mangled or something. In any case, I am going to look more into this whole "I'm not sure that my |
|
Oh, I'm wrong: It works fine because the call to I should probably still have a test for this. And this is a reminder that it's nice not to have to deal with enclosing classes at all.... Really, the more checking that we can do just based on questions like "Is the target type here a primitive type?" (like https://errorprone.info/bugpattern/NullTernary), the better. Probably |
It does, but I got confused in #4225. PiperOrigin-RevId: 594090535
It does, but I got confused in #4225. PiperOrigin-RevId: 594123682
|
I don't have any theories about how that NPE could have happened. I don't know much about the interaction between sbt and javac. My current best idea is to add a more descriptive assertion that would catch that NPE, and see if it happens again. |
PiperOrigin-RevId: 595213359
PiperOrigin-RevId: 595414757
|
@caitlinshk I added an assertion that should print more information if this happens again and released that change as |
|
Yes definitely! It wasn't super reproducible but I'll let you know if I see it again. |
…e_core to v2.24.1 [](https://renovatebot.com) This PR contains the following updates: | Package | Change | Age | Adoption | Passing | Confidence | |---|---|---|---|---|---| | [com.google.errorprone:error_prone_core](https://errorprone.info) ([source](https://togithub.com/google/error-prone)) | `2.23.0` -> `2.24.1` | [](https://docs.renovatebot.com/merge-confidence/) | [](https://docs.renovatebot.com/merge-confidence/) | [](https://docs.renovatebot.com/merge-confidence/) | [](https://docs.renovatebot.com/merge-confidence/) | --- ### Release Notes <details> <summary>google/error-prone (com.google.errorprone:error_prone_core)</summary> ### [`v2.24.1`](https://togithub.com/google/error-prone/releases/tag/v2.24.1): Error Prone 2.24.1 Changes: - Add an assertion to try to help debug [https://github.com/google/error-prone/issues/4225](https://togithub.com/google/error-prone/issues/4225) Full Changelog: google/error-prone@v2.24.0...v2.24.1 ### [`v2.24.0`](https://togithub.com/google/error-prone/releases/tag/v2.24.0): Error Prone 2.24.0 New checks: - [`MultipleNullnessAnnotations`](https://errorprone.info/bugpattern/MultipleNullnessAnnotations): Discourage multiple nullness annotations - [`NullableTypeParameter`](https://errorprone.info/bugpattern/NullableTypeParameter): Discourage nullness annotations on type parameters - [`NullableWildcard`](https://errorprone.info/bugpattern/NullableWildcard): Discourage nullness annotations on wildcards - [`SuperCallToObjectMethod`](https://errorprone.info/bugpattern/SuperCallToObjectMethod): Generalization of `SuperEqualsIsObjectEquals`, now covers `hashCode` Full Changelog: google/error-prone@v2.23.0...v2.24.0 </details> --- ### Configuration 📅 **Schedule**: Branch creation - "after 10pm every weekday,before 6am every weekday" (UTC), Automerge - At any time (no schedule defined). 🚦 **Automerge**: Enabled. ♻ **Rebasing**: Whenever PR is behind base branch, or you tick the rebase/retry checkbox. 🔕 **Ignore**: Close this PR and you won't be reminded about this update again. --- - [ ] <!-- rebase-check -->If you want to rebase/retry this PR, check this box --- This PR has been generated by [Mend Renovate](https://www.mend.io/free-developer-tools/renovate/). View repository job log [here](https://developer.mend.io/github/apereo/cas). <!--renovate-debug:eyJjcmVhdGVkSW5WZXIiOiIzNy4xMDMuMSIsInVwZGF0ZWRJblZlciI6IjM3LjEyNy4wIiwidGFyZ2V0QnJhbmNoIjoibWFzdGVyIn0=-->
|
Just FYI I still haven't seen this error again, so feel free to close. |
|
Thanks for following up! |
…e_core to v2.24.1 [](https://renovatebot.com) This PR contains the following updates: | Package | Change | Age | Adoption | Passing | Confidence | |---|---|---|---|---|---| | [com.google.errorprone:error_prone_core](https://errorprone.info) ([source](https://togithub.com/google/error-prone)) | `2.23.0` -> `2.24.1` | [](https://docs.renovatebot.com/merge-confidence/) | [](https://docs.renovatebot.com/merge-confidence/) | [](https://docs.renovatebot.com/merge-confidence/) | [](https://docs.renovatebot.com/merge-confidence/) | --- ### Release Notes <details> <summary>google/error-prone (com.google.errorprone:error_prone_core)</summary> ### [`v2.24.1`](https://togithub.com/google/error-prone/releases/tag/v2.24.1): Error Prone 2.24.1 Changes: - Add an assertion to try to help debug [https://github.com/google/error-prone/issues/4225](https://togithub.com/google/error-prone/issues/4225) Full Changelog: google/error-prone@v2.24.0...v2.24.1 ### [`v2.24.0`](https://togithub.com/google/error-prone/releases/tag/v2.24.0): Error Prone 2.24.0 New checks: - [`MultipleNullnessAnnotations`](https://errorprone.info/bugpattern/MultipleNullnessAnnotations): Discourage multiple nullness annotations - [`NullableTypeParameter`](https://errorprone.info/bugpattern/NullableTypeParameter): Discourage nullness annotations on type parameters - [`NullableWildcard`](https://errorprone.info/bugpattern/NullableWildcard): Discourage nullness annotations on wildcards - [`SuperCallToObjectMethod`](https://errorprone.info/bugpattern/SuperCallToObjectMethod): Generalization of `SuperEqualsIsObjectEquals`, now covers `hashCode` Full Changelog: google/error-prone@v2.23.0...v2.24.0 </details> --- ### Configuration 📅 **Schedule**: Branch creation - "after 10pm every weekday,before 6am every weekday" (UTC), Automerge - At any time (no schedule defined). 🚦 **Automerge**: Enabled. ♻ **Rebasing**: Whenever PR is behind base branch, or you tick the rebase/retry checkbox. 🔕 **Ignore**: Close this PR and you won't be reminded about this update again. --- - [ ] <!-- rebase-check -->If you want to rebase/retry this PR, check this box --- This PR has been generated by [Mend Renovate](https://www.mend.io/free-developer-tools/renovate/). View repository job log [here](https://developer.mend.io/github/apereo/cas). <!--renovate-debug:eyJjcmVhdGVkSW5WZXIiOiIzNy4xMDMuMSIsInVwZGF0ZWRJblZlciI6IjM3LjEyNy4wIiwidGFyZ2V0QnJhbmNoIjoibWFzdGVyIn0=-->
](https://renovatebot.com){kind=link}
Hi there,
I'm running my project's local server (https://github.com/civiform/civiform/wiki/Getting-started#running-a-local-server), and I ran into this issue. It asked me to report it, so here I am :)
The text was updated successfully, but these errors were encountered: