Prevent ConstructorLeaksThis false positive on constructor reference

Fixes #655.
google · Oct 23, 2017 · 495b0be · 495b0be
1 parent 319c505
commit 495b0be
Show file tree

Hide file tree

Showing 2 changed files with 12 additions and 1 deletion.
diff --git a/core/src/main/java/com/google/errorprone/bugpatterns/ConstructorLeaksThis.java b/core/src/main/java/com/google/errorprone/bugpatterns/ConstructorLeaksThis.java
@@ -29,6 +29,7 @@
 import com.sun.source.tree.MemberSelectTree;
 import com.sun.source.tree.Tree;
 import com.sun.source.util.TreeScanner;
+import com.sun.tools.javac.code.Symbol;
 import com.sun.tools.javac.code.Symbol.ClassSymbol;
 import javax.lang.model.element.Name;
 
@@ -83,7 +84,8 @@ public Void visitAssignment(AssignmentTree node, Void unused) {
 
   private void checkForThis(
       ExpressionTree node, Name identifier, ClassSymbol thisClass, VisitorState state) {
-    if (identifier.contentEquals("this") && thisClass.equals(ASTHelpers.getSymbol(node).owner)) {
+    Symbol sym = ASTHelpers.getSymbol(node);
+    if (!sym.isConstructor() && identifier.contentEquals("this") && thisClass.equals(sym.owner)) {
       state.reportMatch(describeMatch(node));
     }
   }

diff --git a/...st/java/com/google/errorprone/bugpatterns/testdata/ConstructorLeaksThisNegativeCases.java b/...st/java/com/google/errorprone/bugpatterns/testdata/ConstructorLeaksThisNegativeCases.java
@@ -97,4 +97,13 @@ static class Inner {
     @SuppressWarnings("ConstructorLeaksThis")
     final FixtureController that = new FixtureController(this);
   }
+
+  static final class WithTwoConstructors {
+    public WithTwoConstructors() {
+      // 'this' references another constructor, not an object
+      this(0);
+    }
+
+    public WithTwoConstructors(int i) {}
+  }
 }