-
Notifications
You must be signed in to change notification settings - Fork 22
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add .gni containing lists of files needed by GN #152
Comments
I totally get why you want this, I'm just not sure how the emboss project will keep it up to date. We're currently only setup for bazel builds. Maybe adding a tool that can generate these files as part of the bazel build is what we want? |
For concrete examples we have:
python_library_host {
name: "emboss_compiler",
srcs: [
"compiler/back_end/cpp/*.py",
"compiler/back_end/util/*.py",
"compiler/front_end/*.py",
"compiler/util/*.py",
],
data: [
"compiler/back_end/cpp/generated_code_templates",
"compiler/front_end/error_examples",
"compiler/front_end/prelude.emb",
"compiler/front_end/reserved_words",
],
} Additionally each of those has some sort of target for the C++ header library as well, something along the lines of:
So it'd be nice to cover that case too. |
358665524 is an example of the kinds of bugs we run into. This is because Fuchsia builds require all inputs to listed - https://fuchsia.dev/fuchsia-src/development/build/hermetic_actions. |
I created Pigweed issue Update emboss build rules to pull their file list from emboss repo [359386289] - Pigweed for the work that will need to happen in Pigweed alongside changes here in Emboss. |
Provide a JSON file that lists files used in the build. It will to be used by downstream, non-bazel builds. For example, https://fxrev.dev/1100339 is one planned usage of this. Emboss Issue: google#152 Pigweed Bug: https://pwbug.dev/359386289 Change-Id: Id33d879cea95d86f6cc7a16cd395a8c1a4380cbf
Provide a JSON file that lists files used in the build. It will be used by downstream, non-bazel builds. For example, https://fxrev.dev/1100339 is one planned usage of this. Emboss Issue: google#152 Pigweed Bug: https://pwbug.dev/359386289 Change-Id: Id33d879cea95d86f6cc7a16cd395a8c1a4380cbf
Provide a JSON file that lists files used in the build. It will be used by downstream, non-bazel builds. For example, https://fxrev.dev/1100339 is one planned usage of this. Emboss Issue: google#152 Pigweed Bug: https://pwbug.dev/359386289 Change-Id: Id33d879cea95d86f6cc7a16cd395a8c1a4380cbf
Currently we have to maintain lists of Emboss files for use in GN build targets in Pigweed, including the compiler python files and the cpp_utils headers. It would be much more maintainable if there was a .gni file in upstream Emboss containing these file lists.
The text was updated successfully, but these errors were encountered: