Skip to content

Commit

Permalink
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
delete artifact upload/download; it is not faster
Browse files Browse the repository at this point in the history
austinEng authored Nov 7, 2023

Verified

This commit was created on GitHub.com and signed with GitHub’s verified signature. The key has expired.
1 parent f80f996 commit 70e9f3d
Showing 2 changed files with 0 additions and 42 deletions.
21 changes: 0 additions & 21 deletions .github/workflows/cmake.yml
Original file line number Diff line number Diff line change
@@ -53,19 +53,6 @@ jobs:
shell: bash
run: |
echo "build-output-dir=${{ github.workspace }}/out/build" >> "$GITHUB_OUTPUT"
echo "build-key=${{ runner.os }}-${{github.workflow}}-${{ matrix.build_type }}-${{ matrix.c_compiler }}" >> "$GITHUB_OUTPUT"
# Only download workspace artifacts on pull requests. CI builds should start from a fresh state.
- name: Download workspace artifacts
uses: dawidd6/action-download-artifact@v2
if: ${{ github.event_name == 'pull_request' }}
with:
workflow_conclusion: success
name: workspace-${{ steps.strings.outputs.build-key }}
search_artifacts: true
path: ${{ steps.strings.outputs.build-output-dir }}
if_no_artifact_found: warn
continue-on-error: true
- name: Install Ubuntu build dependencies
if: matrix.os == 'ubuntu-latest'
@@ -107,11 +94,3 @@ jobs:
run: cmake --build ${{ steps.strings.outputs.build-output-dir }} --config ${{ matrix.build_type }}
env:
SCCACHE_GHA_ENABLED: "true"

# Always upload workspace artifacts. Eventually only do this for pushes to main.
- name: Upload workspace artifacts
uses: actions/upload-artifact@v3
with:
name: workspace-${{ steps.strings.outputs.build-key }}
path: ${{ steps.strings.outputs.build-output-dir }}
retention-days: 7
21 changes: 0 additions & 21 deletions .github/workflows/gn.yml
Original file line number Diff line number Diff line change
@@ -40,19 +40,6 @@ jobs:
shell: bash
run: |
echo "build-output-dir=out/build" >> "$GITHUB_OUTPUT"
echo "build-key=${{ runner.os }}-${{github.workflow}}" >> "$GITHUB_OUTPUT"
# Only download workspace artifacts on pull requests. CI builds should start from a fresh state.
- name: Download workspace artifacts
uses: dawidd6/action-download-artifact@v2
if: ${{ github.event_name == 'pull_request' }}
with:
workflow_conclusion: success
name: workspace-${{ steps.strings.outputs.build-key }}
search_artifacts: true
path: ${{ github.workspace }}/${{ steps.strings.outputs.build-output-dir }}
if_no_artifact_found: warn
continue-on-error: true
- name: Set up checkout
run: |
@@ -87,11 +74,3 @@ jobs:
env:
SCCACHE_GHA_ENABLED: "true"
DEPOT_TOOLS_WIN_TOOLCHAIN: 0

# Always upload workspace artifacts. Eventually only do this for pushes to main.
- name: Upload workspace artifacts
uses: actions/upload-artifact@v3
with:
name: workspace-${{ steps.strings.outputs.build-key }}
path: ${{ github.workspace }}/${{ steps.strings.outputs.build-output-dir }}
retention-days: 7

0 comments on commit 70e9f3d

Please sign in to comment.