Fail fast with better error message when trying to use a type paramet…

…er with the @AssistedFactory creator method. We're considering supporting this feature in the future, but until then we're adding a better error message. See #2279 RELNOTES=Issue #2279: Adds better error message when trying to use a type parameter with @AssistedFactory creator method. PiperOrigin-RevId: 354389636
google · Jan 28, 2021 · 9a90151 · 9a90151
1 parent 89b334d
commit 9a90151
Show file tree

Hide file tree

Showing 2 changed files with 36 additions and 0 deletions.
diff --git a/java/dagger/internal/codegen/AssistedFactoryProcessingStep.java b/java/dagger/internal/codegen/AssistedFactoryProcessingStep.java
@@ -160,6 +160,12 @@ ValidationReport<TypeElement> validate(TypeElement factory) {
                   methodType.getReturnType()),
               method);
         }
+        if (!method.getTypeParameters().isEmpty()) {
+          report.addError(
+              "@AssistedFactory does not currently support type parameters in the creator "
+                  + "method. See https://github.com/google/dagger/issues/2279",
+              method);
+        }
       }
 
       if (abstractFactoryMethods.size() > 1) {

diff --git a/javatests/dagger/internal/codegen/AssistedFactoryErrorsTest.java b/javatests/dagger/internal/codegen/AssistedFactoryErrorsTest.java
@@ -772,4 +772,34 @@ public void testInaccessibleFoo() {
       assertThat(compilation).succeeded();
     }
   }
+
+  @Test
+  public void testAssistedFactoryMethodWithTypeParametersFails() {
+    JavaFileObject foo =
+        JavaFileObjects.forSourceLines(
+            "test.Foo",
+            "package test;",
+            "",
+            "import dagger.assisted.AssistedInject;",
+            "import dagger.assisted.AssistedFactory;",
+            "",
+            "class Foo<T> {",
+            "  @AssistedInject",
+            "  Foo() {}",
+            "",
+            "  @AssistedFactory",
+            "  interface FooFactory {",
+            "    <T> Foo<T> create();",
+            "  }",
+            "}");
+
+    Compilation compilation = compilerWithOptions(compilerMode.javacopts()).compile(foo);
+    assertThat(compilation).failed();
+    assertThat(compilation).hadErrorCount(1);
+    assertThat(compilation)
+        .hadErrorContaining(
+            "@AssistedFactory does not currently support type parameters in the creator method.")
+        .inFile(foo)
+        .onLine(12);
+  }
 }