Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[bazel] inline platforms and remove platforms.bzl #381

Merged
merged 3 commits into from
Dec 18, 2024
Merged

[bazel] inline platforms and remove platforms.bzl #381

merged 3 commits into from
Dec 18, 2024

Conversation

gchatelet
Copy link
Collaborator

@gchatelet gchatelet commented Dec 18, 2024 •
edited by Mizux
Loading

note: replace PLATFORM_CPU_X86_64 by "@platforms//cpu:x86_32", "@platforms//cpu:x86_64"

Mizux
Mizux approved these changes Dec 18, 2024
View reviewed changes
Copy link
Collaborator

@Mizux Mizux left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@gchatelet gchatelet merged commit 5cfee57 into main Dec 18, 2024
53 checks passed
@gchatelet gchatelet deleted the remove_platforms_bzl branch December 18, 2024 10:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Mizux Mizux Mizux approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@gchatelet @Mizux