-
Notifications
You must be signed in to change notification settings - Fork 263
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update amd64 macos workflow to use X86 arch #355
Conversation
6ef9ff6
to
be95b3b
Compare
success: install failed: error message:
|
@gchatelet, @Mizux, this PR is ready to review please take a look. |
@@ -10,7 +10,7 @@ on: | |||
jobs: | |||
# Building using the github runner environement directly. | |||
bazel: | |||
runs-on: macos-latest | |||
runs-on: macos-13 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can you add # Using x86 processors, ref: https://github.com/actions/runner-images
after macos-13
?
@@ -10,7 +10,7 @@ on: | |||
jobs: | |||
# Building using the github runner environement directly. | |||
xcode: | |||
runs-on: macos-latest | |||
runs-on: macos-13 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
ditto
@@ -26,7 +26,7 @@ jobs: | |||
- name: Install | |||
run: cmake --build build --config Release --target install -v | |||
make: | |||
runs-on: macos-latest | |||
runs-on: macos-13 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
ditto
3773c88
to
7cfa0cf
Compare
Thank you @toor1245 ! 🙏 |
Github Actions added support M1, thus macOS supports arm64 and amd64 in actions:
macos-latest
is arm64 architecturemacos-13
is amd64 architecturesee details:
https://docs.github.com/en/actions/using-github-hosted-runners/using-github-hosted-runners/about-github-hosted-runners
it looks like
macos-latest-large
is not supported to use amd64https://github.com/actions/runner-images?tab=readme-ov-file#available-images
Also, we should add CI/CD arm64 architecture support for macOS M1 CPUs in the separate patch and fix tests.
See details: https://github.com/google/cpu_features/actions/runs/10499466482/job/29086289583