New code layout - breaking change in cpu_features_macros.h #194
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
toor1245
reviewed
Oct 26, 2021
| if (CpuFeatures_StringView_IsEquals(key, str("Features"))) { | ||
| for (size_t i = 0; i < AARCH64_LAST_; ++i) { | ||
| kSetters[i](&info->features, CpuFeatures_StringView_HasWord( | ||
| value, kCpuInfoFlags[i], ' ')); |
There was a problem hiding this comment.
kCpuInfoFlags undeclared variable
There was a problem hiding this comment.
Thx! This is not ready for review yet :-)
There was a problem hiding this comment.
Ready for review if you want to have a look @toor1245 .
Mizux
reviewed
Oct 27, 2021
gchatelet
changed the title
toor1245
approved these changes
Oct 28, 2021
|
Thx for the review. Submitting now. |
Mizux
approved these changes
Oct 28, 2021
gchatelet
added
the
API Change
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This commit helps with platform code separation (fixes #3). It should also help with the build as we can simply include all
impl_*.cfiles regardless of OS / arch.Note: this patch contains breaking changes in
include/cpu_features_macros.hCPU_FEATURES_OS_LINUX_OR_ANDROIDdoes not exist anymoreCPU_FEATURES_OS_FREEBSD,CPU_FEATURES_OS_ANDROIDandCPU_FEATURES_OS_LINUXare now mutually exclusive (i.e.CPU_FEATURES_OS_ANDROIDdoes not implyCPU_FEATURES_OS_LINUX)CPU_FEATURES_OS_DARWINhas been renamed intoCPU_FEATURES_OS_MACOSto be able to target non-Mac Apple products (IOS, TV, WATCH). They are now targetable withCPU_FEATURES_OS_IPHONE. This matches Apple naming convention described in this stackoverflow.