Update issue type and component for VRP uploaded bugs #4580
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -1056,6 +1059,19 @@ def update_component_labels_and_id(policy, testcase, issue): | |||
| component_id = _get_predator_result_item(testcase, | |||
| 'suspected_buganizer_component_id') | |||
|
|
|||
| # These bugs were filed via the direct upload and hence specific to the | |||
| # google issue tracker. | |||
| if hasattr(issue, | |||
There was a problem hiding this comment.
when would it not have component_id?
You can replace this with getattr(issue, 'component_id', None) == VRP_UPLOAD_COMPONENT_ID.
There was a problem hiding this comment.
i believe an issue wouldnt have component_id for non google issue tracker (monorail, jira)
but ooh thank you done!
pgrace-google
force-pushed
the
type_change
branch
from
43609e4 to
00584fb
Compare
pgrace-google
commented
Jan 20, 2025
| @@ -1056,6 +1059,19 @@ def update_component_labels_and_id(policy, testcase, issue): | |||
| component_id = _get_predator_result_item(testcase, | |||
| 'suspected_buganizer_component_id') | |||
|
|
|||
| # These bugs were filed via the direct upload and hence specific to the | |||
| # google issue tracker. | |||
| if hasattr(issue, | |||
There was a problem hiding this comment.
i believe an issue wouldnt have component_id for non google issue tracker (monorail, jira)
but ooh thank you done!
pgrace-google
requested review from
jonathanmetzman,
vitorguidi and
hogo6002
and removed request for
hogo6002
pgrace-google
force-pushed
the
type_change
branch
from
00584fb to
009393f
Compare
|
(just rebasing) |
pgrace-google
added a commit
to pgrace-google/clusterfuzz
that referenced
this pull request
Feb 5, 2025
pgrace-google
added a commit
that referenced
this pull request
Feb 5, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Question 0: dont review this yet im running tests just to make sure its right
Question 1: i imagine there is a better place to put the component ids, but i havent been able to find it. where is it??