Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Monitoring] Make appengine crons emit metrics #4572

Merged
merged 1 commit into from
Jan 2, 2025

Conversation

vitorguidi
Copy link
Collaborator

@vitorguidi vitorguidi commented Jan 2, 2025

Appengine crons are currently not instrumented, so we cannot get testcase metrics for the google 3 deployment. This PR fixes that.

Part of #4271

Copy link
Collaborator

@jonathanmetzman jonathanmetzman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@vitorguidi vitorguidi changed the title Make appengine crons emit metrics [Monitoring] Make appengine crons emit metrics Jan 2, 2025
@vitorguidi vitorguidi merged commit 13fb6f2 into master Jan 2, 2025
7 checks passed
@vitorguidi vitorguidi deleted the chore/fix-appengine-cron-metric branch January 2, 2025 14:29
jonathanmetzman pushed a commit that referenced this pull request Jan 8, 2025
Appengine crons are currently not instrumented, so we cannot get
testcase metrics for the google 3 deployment. This PR fixes that.

Part of #4271
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants